Use of uninitialised geometry variable

Issue #56 resolved
David Dickinson created an issue

In gs2_main initialize_equations we use quantities out of the geometry module, specifically surfarea and dvdrhon. In s-alpha geometry the variables in the geometry module aren't certain to be setup as the entire geometry calculation is done in theta_grid. In particular, it seems surfarea isn't set to anything which can cause unusual problems when we do try to use it here.

My understanding is that theta_grid should act as the geometry interface -- i.e. we should get all our geometrical quantities from here rather than direct from geometry (indeed the quantities in geometry could be on a slightly different theta grid).

There are only a few other places where we use geometry directly and we should look at tidying these up to use theta_grid instead.

Comments (1)

  1. Log in to comment