Inconsistent value of `eps` written to netcdf file for s-alpha runs

Issue #93 resolved
David Dickinson created an issue

We write many of the values from theta_grid_paramsinto the netcdf output. The value of eps, will generally not match that provided by the input file (or the default input value if not set). This can be confusing and potentially cause problems, say in post-processing attempts to use this value.

The reason for this inconsistency is that in the main/general theta_gridmodule we recalculate eps as eps = 1 - Bmin/Bmax. There is an associated comment suggesting this is required for parts of the collision operator. Having searched the code it seems this value isn’t actually used elsewhere, as such I think we are free to remove this calculation/redefinition.

Comments (1)

  1. Log in to comment