Fix segfault which occurred when
David Dickinson
Branch: bugfix/avoid_segfault_inmemory_force_maxwell
Branch: next
Merged
Merged pull request
Merged in bugfix/avoid_segfault_inmemory_force_maxwell (pull request #105)
Merged in bugfix/avoid_segfault_inmemory_force_maxwell (pull request #105)
init_knobs:in_memory=.true. and fields_knobs:force_maxwell_reinit=.false.
Key change is
if (overrides_obj%force_maxwell_reinit) then
if (.not.overrides_obj%force_maxwell_reinit) then
This avoids the segfault by ensuring arrays are allocated at initialisation time. We could(/should) probably just check the
allocated
status at the point where we want to store values but that would be a larger change.Â
This should address #55 (at least in part)
Â
Also fixes
Â
Potential hang with
in_memory=.true.
– added missing broadcastFix templated generation from ruby for builds without the new diagnostics.