Merged in bugfix/fix-optimization-test (pull request #86)
f018649·Author: Joseph Parker·Closed by: Joseph Parker·2019-03-13
Description
Currently, the `gs2_optimisation` test fails on some machines with array out-of-bounds errors (see #46 and #48). I haven't been able to reproduce this, but it seems likely the cause is that gs2 cannot robustly handle changing the value of nproc within an execution.
This PR disables the nproc scan part of the optimization test, by setting max_unused_procs = 0. Now the number of procs is not varied, and out-of-bounds errors should not occur. Hopefully.
Update: We’ve decided to delete non-functional tests, and re-implement them in pfunit. Merging this branch keeps the test history and the partial fix.
Currently, the `gs2_optimisation` test fails on some machines with array out-of-bounds errors (see #46 and #48). I haven't been able to reproduce this, but it seems likely the cause is that gs2 cannot robustly handle changing the value of
nprocwithin an execution.This PR disables the
nprocscan part of the optimization test, by settingmax_unused_procs = 0. Now the number of procs is not varied, and out-of-bounds errors should not occur. Hopefully.Â
Addresses #46
Addresses #48
Update: We’ve decided to delete non-functional tests, and re-implement them in pfunit. Merging this branch keeps the test history and the partial fix.