Pull requests

#8 Merged
jimmy_kloss/hachoir_my hachoir_my
haypo/hachoir hachoir

enhancing mkv spec compliance

  1. jimmy_kloss

As a respond to Issue #44, here my pull request. It differs from the original, let me explain:

I checked the spec again (http://matroska.org/technical/specs/index.html#languages) it states that all 3 letter language codes according to ISO-639-2 are valid values. And according to that (http://www.loc.gov/standards/iso639-2/php/English_list.php) "mis", "und" (also "mul", "zxx") are valid codes. These special codes are already listed in hachoir-core/iso639.py and I see no reason why to filter them out.

"und" stands for "Undetermined", meaning the creator (of an mkv) didn't set a specific language code, which is common for video tracks. An exception would be Star Wars where you have that floating text at the beginning, which got translated in other languages.

"mis" stands for "Uncoded languages", meaning the language has no ISO-639-2 code. This was mistakenly stated as "miscellaneous" (instead of "missing") in iso639.py

"mul" stands for "Multiple languages" "zxx" stands for "No linguistic content"

Since the mkv spec requires a language tag or the default value, filtering arbitrary valid values isn't the right way to go IMO. After all hachoir is supposed to show me the metadata, not to hide it. My filemanager already does that for me. ;)

Comments (0)