Close button and exit menu close dock windows instead of application

[Former user]

Originally reported on Google Code with ID 121

What steps will reproduce the problem?
1. Open any of the 4 possible side windows, docked (show function list, ...)
2. Close program

What is the expected output? What do you see instead?
It only closes the docked side-windows
You have to close another time to close the program
So it don't remembers the docked windows

What version of the product are you using? On what operating system?
0.9 on windows xp sp2

Reported by gabriel.gross on 2007-12-02 23:30:51

[Former user]

``` Could not verify this on the Linux version. But while I was playing with the side windows, I found another bug: 1. Open the variables window. 2. Detach it from the main window 3. Close SpeedCrunch without closing the variables window before 4. Re-open SpeedCrunch. Not only is the variable window not showing (even though the menu item is marked), I was unable to make it visible again by unmarking and marking the menu item in the settings menu. ```

Reported by `wolf.lammen` on 2007-12-03 06:25:05

[Former user]

``` I just checked the windows version. The close event is grabbed by the docking window. ```

Reported by `wolf.lammen` on 2007-12-03 21:05:51

[Former user]

``` The bug mentioned in comment 1 is connected to the following code snippet from applySettings in crunch.cpp:

if( settings->stayAlwaysOnTop ) setWindowFlags( windowFlags() | Qt::WindowStaysOnTopHint ); else setWindowFlags( windowFlags() & (~ Qt::WindowStaysOnTopHint) ); show();

If you delete the show() command, all floating windows happily appear in the right position. But show() has a meaning here: It makes the main window reappear, if the stay-on-top feature is toggled. I don't have a clue why the show() command conflicts with floating dock-windows. Some deeper insight into QT seems necessary to explain this behaviour. Unfortunately, I have no experience with QT, so I am not the best choice to fix this properly.

```

Reported by `wolf.lammen` on 2007-12-07 01:45:51

[Former user]

``` Could not verify this in the Linux version ```

Reported by `wolf.lammen` on 2007-12-08 07:55:47

[Former user]

``` I can reproduce this in Linux as well (0.9 and trunk). Changing title. ```

Reported by `helder.pereira.correia` on 2007-12-11 22:21:16 - Status changed: `Accepted` - Labels added: Milestone-0.10

[Former user]

``` Switching the virtual screen also close the dock windows. ```

Reported by `helder.pereira.correia` on 2007-12-13 21:28:50

[Former user]

``` Not able to duplicate in Kubuntu using speedcrunch 0.8

eek... i need to upgrade.

```

Reported by `goodtimetribe` on 2007-12-17 04:01:10

[Former user]

``` I found this same problem and solved it by emitting a signal from Crunch when the action of quitting goes on, so that the QApplication catches it and quits. Here goes a patch. It's my first patch so I'm not sure if this is how it's done, it should be applied to the 'main' directory since it makes changes to main.cpp, crunch.hxx and crunch.cpp. Keep up the good work! ```

Reported by `csanchisb` on 2007-12-31 15:48:26

<hr>

• *Attachment: [main.patch](https://storage.googleapis.com/google-code-attachments/speedcrunch/issue-121/comment-9/main.patch)*

[Former user]

``` Fixed in revision 951. Thank you csanchisb for your inspiring patch! ```

Reported by `helder.pereira.correia` on 2008-01-04 00:49:01 - Status changed: `Fixed`

[Former user]

``` Refactored and much better fix available in trunk (revision 1079). ```

Reported by `helder.pereira.correia` on 2008-02-18 14:29:26