Improve bit numbering in the BitField widget

Issue #660 closed
Former user created an issue

Bit numbering in the BitField widget is done in a way that requires significant effort to infer bit indices. I.e. either pointing to the BitWidget with the mouse cursor and waiting for the tooltip to appear or manual calculation is needed. Much more comfortable would be to put every bit's index into every BitWidget.

Proposed improvement attached.

Comments (5)

  1. Pol Welter

    Not sure if I like this one. It is visually noisy. Also, I'd think that for most people it's more interesting to see e.g. this is the 3rd bit from the 5th byte, rather than this is bit 34.

  2. l.inc

    A can't agree on the noisiness. The BitFieldWidget takes a lot of screen space without providing much useful information, so it looks rather too empty for me. I haven't met any practical use cases for "this is the 3rd bit from the 5th byte", but the patch does not make it worse for such rather unusual demands. On the other hand getting bit configuration of some hardware register printed in a raw value to the debug output is something I need on a daily basis, and this often includes inferring indices of each individual bit.

    Thanks for applying the other 3 patches so quickly btw.

  3. Helder Correia repo owner

    I can totally see where @l.inc is coming from. I was also feeling the noise that Pol mentioned but I got used to it and think the looks are surprisingly nice. @I.inc I prefer when contributions are uploaded as a pull request instead of a patch attachment in the bug tracker. Do you mind doing that? Thanks

  4. Log in to comment