FTBFS due to problem introduced in 46dc16e

Issue #663 closed
Peter Mattern created an issue

Attempts to build recent checkouts on Arch Linux fail with

[ 82%] Building CXX object CMakeFiles/speedcrunch.dir/gui/bitfieldwidget.cpp.o
/usr/local/peter/Tests/SpeedCrunch/Projekt/speedcrunch/src/gui/bitfieldwidget.cpp: In member function ‘void BitFieldWidget::updateFieldLayout()’:
/usr/local/peter/Tests/SpeedCrunch/Projekt/speedcrunch/src/gui/bitfieldwidget.cpp:194:73: error: ‘log2’ was not declared in this scope
         bytesPerRow = pow(2, floor(log2(availableWidth / byteWidgetWidth)));
                                                                         ^
/usr/local/peter/Tests/SpeedCrunch/Projekt/speedcrunch/src/gui/bitfieldwidget.cpp:194:74: error: ‘floor’ was not declared in this scope
         bytesPerRow = pow(2, floor(log2(availableWidth / byteWidgetWidth)));
                                                                          ^
/usr/local/peter/Tests/SpeedCrunch/Projekt/speedcrunch/src/gui/bitfieldwidget.cpp:194:75: error: ‘pow’ was not declared in this scope
         bytesPerRow = pow(2, floor(log2(availableWidth / byteWidgetWidth)));
                                                                           ^
[ 82%] Building CXX object CMakeFiles/speedcrunch.dir/gui/bookdock.cpp.o
make[2]: *** [CMakeFiles/speedcrunch.dir/build.make:485: CMakeFiles/speedcrunch.dir/gui/bitfieldwidget.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:322: CMakeFiles/speedcrunch.dir/all] Error 2
make: *** [Makefile:161: all] Error 2

Regression tests suggest the problem was introduced in 46dc16e. FTBFS and error message are still the same in current 5a8127e. cmake was invoked without any option (variable).

Comments (10)

  1. Tey'

    Thanks for your report. I should be blamed for that: the recent changes compiled successfully on both Windows and Ubuntu, so I didn't bother adding the required header.

    Please confirm this is fixed in c8007d2 (latest commit).

  2. Peter Mattern reporter

    @heldercorreia
    (Wrongly using this issue as it doesn't seem to be easy to reach you otherwise:)
    Some days ago I've tried to subscribe to Google group speedcrunch by mail, but the request seems to be pending, apparently still awaiting approval.
    Any chance you can look into this or tell me what else is wrong here?

  3. Helder Correia repo owner

    @pmattern Did it work now? I didn't get an email from Google about your request for some reason.

  4. Peter Mattern reporter

    @heldercorreia
    Yes, I've just got the confirmation mail. Thanks.
    Btw. another way to reach you for questions like this, e. g. a mail address or an IRC channel, doesn't exist, does it?

  5. Helder Correia repo owner

    @pmattern Issue tracker, mailing list and blog are the preferred mechanisms for reaching out. Maybe I should create a FB group too.

  6. Log in to comment