Use take start offset to set anacrusis

Create issue
Issue #3 resolved
Benjamin Klum repo owner created an issue

Before, I considered treating item snap offset as anacrusis.

Following things make the take start offset a better candidate:

  • Item snap offset is an item-wide thing. You can't determine the anacrusis on take level (take level makes more sense).
  • The loop indicators when prolonging the item to the right make only sense if you adjust the take offset anyway. The loop border should be on the first beat, not on the start of the anacrusis.
  • Item snap offset doesn't "survive" playrate changes. It refers to another position in the source when the playrate is changes. The anacrusis should stay the same!

Comments (12)

  1. Benjamin Klum reporter

    re #3 When filling slot with selected item and detecting a take start offset that could be meant as an anacrusis, ask the user about it

    → <<cset d32ff4eb84d2>>

  2. Benjamin Klum reporter

    re #3 Fix negative anacrusis when playing by completely removing the take start offset (negative anacrusis == take start offset > source length)

    → <<cset a8fddd30c1c8>>

  3. Benjamin Klum reporter

    re #3 Get timing right when starting clip after tempo change by modifying playrate before doing all the playrate-dependent calculations

    → <<cset 2a7e2852d8dd>>

  4. Log in to comment