crash when trying to target learn

[Former user]

setup:

first mapping, reapers 'volume adjustment as target also the plguin parameters/plugins didnt really show up

source learning worked as intended

reaper v5.7 x64

no issues with realearn version from february (no go there function).

[Thomas Teschauer]

now i have an account hit me up for further information

[Benjamin Klum]

I cannot reproduce this unfortunately. You are on Windows I suppose. What are the exact steps you do?

I do:

1. New project
2. Add track with ReaLearn as input FX
3. Add mapping
4. Edit
5. Target => Learn
6. Move volume slider of that track
7. Target is assigned as expected

[Boscop]

It happened to me frequently in Reaper/ReaLearn 32-bit too, very frustrating..

[Ian Currie]

This is happening to me too.

Im on Windows 10 64x, running Reaper 64x. Reaper 5.7

My project is relatively large (41 tracks), designed for live use, with two audio inputs (mic and guitar), and various midi devices (FCB1010 foot controller, nanoKontrol II, Akai keyboard, Alesis PercPed). I use SWS live configs to switch between routings and tracks so I have hands free preset swithching with my FCB1010 - for preset switching I dont use ReaLearn, I just program my FCB1010 to send CC messages.

I am using ReaLearn with the nanoKontrol to control various parameters on different tracks. I have one track that is only for my nanoKontrol II, its sole purpose is to host ReaLearn on its dedicated midi channel. On the input FX i have, so far, 3 instances of ReaLearn (so its easy to manage the various mappings).

My problems started when I started trying to map more things with the nanoKontrol. The crash is always the same. Its when I ask ReaLearn to learn target mapping. I click it and it goes into "learn" mode no problem, then I go to the VST in the track which I want to control and move a parameter of the VST. I can click and drag it, but once I let go, it freezes and then crashes.

https://i.imgur.com/mrCTN2V.gif (showing some of the routings I have set up)

https://i.imgur.com/4pLlFTC.gif (showing how a mapping works on an existing instance of Realearn but not on a new one)

It happens on all VSTs and even on a Reaper fader.

https://i.imgur.com/BqPRFxI.gif

At first the crash happened with only one instance of ReaLearn, then I updated to latest version and it seems to be fixed. Since the crash reappeared, it only seems to happen on new instances of ReaLearn. On the nanoKontrol track I have 3 instances that work and can assign new mappings (although it has crashed occasionally...but then it works after restarting it), now on my 4th instance, I can not make any new mappings without crashing it.

Thing is, with some VSTs I can't even assign the mapping manually because the parameters dont seem to list in the editing menu in Realearn, as a temporary workaround I could just load up the instance of Realearn that actually works but this will get confusing when I need to make a change.

[Ian Currie]

here are the last couple error reports from the windows Event Viewer.

<Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event"> - <System> <Provider Name="Application Error" /> <EventID Qualifiers="0">1000</EventID> <Level>2</Level> <Task>100</Task> <Keywords>0x80000000000000</Keywords> <TimeCreated SystemTime="2018-03-17T11:38:44.249712400Z" /> <EventRecordID>8548</EventRecordID> <Channel>Application</Channel> <Computer>Cavetop</Computer> <Security /> </System> - <EventData> <Data>reaper.exe</Data> <Data>5.7.0.0</Data> <Data>5a307ded</Data> <Data>ReaLearn.dll</Data> <Data>1.1.0.0</Data> <Data>5a2d5404</Data> <Data>c0000409</Data> <Data>00000000006faca8</Data> <Data>1658</Data> <Data>01d3bde452e9acad</Data> <Data>C:\Program Files\REAPER (x64)\reaper.exe</Data> <Data>C:\0 VST\64x\ReaLearn.dll</Data> <Data>01a88f38-c2aa-496a-a454-f767861ea968</Data> <Data /> <Data /> </EventData> </Event>

<Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event"> - <System> <Provider Name="Application Error" /> <EventID Qualifiers="0">1000</EventID> <Level>2</Level> <Task>100</Task> <Keywords>0x80000000000000</Keywords> <TimeCreated SystemTime="2018-03-17T11:39:47.548727200Z" /> <EventRecordID>8550</EventRecordID> <Channel>Application</Channel> <Computer>Cavetop</Computer> <Security /> </System> - <EventData> <Data>reaper.exe</Data> <Data>5.7.0.0</Data> <Data>5a307ded</Data> <Data>ReaLearn.dll</Data> <Data>1.1.0.0</Data> <Data>5a2d5404</Data> <Data>c0000409</Data> <Data>00000000006faca8</Data> <Data>e7c</Data> <Data>01d3bde4891b04be</Data> <Data>C:\Program Files\REAPER (x64)\reaper.exe</Data> <Data>C:\0 VST\64x\ReaLearn.dll</Data> <Data>f5a46363-221b-45d6-95e2-026e9d427417</Data> <Data /> <Data /> </EventData> </Event>

[Ian Currie]

also happening with the same project file on another computer.

[Benjamin Klum]

Hi, can you send the RPP file to [e-mail]?

[Ian Currie]

Sure, no problem. Sent.

[Benjamin Klum]

re #70 Fix dangling pointer crash via shared_from_this

→ <<cset 9eb235358314>>

[Benjamin Klum]

re #70 Comment potentially unsafe code with FIXME-70

→ <<cset 7c1d6a320ac3>>

[Benjamin Klum]

re #70 Comment potentially unsafe code with FIXME-70

→ <<cset a54222cefb66>>

[Benjamin Klum]

re #70 Guard unsafe code in Target

the one that caused this particular crash

→ <<cset 3146a7f46aba>>

[Benjamin Klum]

re #70 Guard unsafe code in Realearn

→ <<cset 727b714cb20f>>

[Benjamin Klum]

re #70 Guard unsafe code in some other model classes

→ <<cset 892c90f8c2d2>>

[Benjamin Klum]

re #70 Guard unsafe code in UI

→ <<cset 1d4c95d08e17>>

[Benjamin Klum]

Could reproduce it, especially when MIDI feedback enabled. I have also fixed similar potential crash causes. Will be in upcoming release (1.2.0).

[Ian Currie]

Well done and thank you!!