service limit seems to be not checked properly

Issue #140 resolved
Jimmy Chu created an issue

otherwise, a user shouldn't be able to create both mysql and phpmyadmin.

Comments (5)

  1. LiAh Sheep
    validate :validate_within_owner_service_limit
    
    def validate_within_owner_service_limit
      if app.owner.service_limit < app.services.size
    

    before creation: app.services.size = 1, so creation is allowed
    after creation: app.services.size = 2, so any save is rolled back

    quick workaround: increase service limit to 2 for now

  2. LiAh Sheep

    fixed locally

    validate :validate_within_owner_service_limit, on: :create
    
    def validate_within_owner_service_limit
      if app.services.size + 1 > app.owner.service_limit
    
  3. Jimmy Chu reporter

    Merge branch 'delayed-job'

    • delayed-job: feature: Delayed job UI add auto refresh (fixing #142) fix: Reverted some custom_url logic fix: Reverted some custom_url logic Service create/destroy delayed job UI (fixing #95, #140) App create/destroy delayed job UI (partial #95) Escaping pull_from to avoid cli injection (#37) Turns out the app is still stopped even after a successful pull Update docs Update docs (first draft) Hide pull_success and pull_error_messages when irrelvant Changed output json parameters Delayed job for app pull (first draft) Update doc for service delayed jobs Service delayed job (first draft) fix: set git_url after app creation (fixing issue #87) fix: update variable name, fixing issue #86 removing deprecated lines multiple bug fixes for delayed job multiple bug fixes for delayed job feature: delayed job for app create & domain bind/unbind “big monster” (first draft)

    → <<cset 66608f77802c>>

  4. Log in to comment