Substitution key not found error with complex factor conditions and references

Issue #302 on hold
Julien Danjou created an issue

Consider the following tox.ini file:

[tox]
envlist = py27,py34

[testenv]
deps =
  py{27,34}: foo

[testenv:docs]
deps = {[testenv]deps}

Running any tox command raises an error:

tox.ConfigError: ConfigError: substitution key '27,34' not found

Comments (7)

  1. Holger Krekel repo owner

    Make substitution engine ignore factor arrays, fix #302

    The fix assumes, that the bug was that the substitution engine - tox.config.Replacer, while recursvely replacing references to actual values, treated factor arrays (like {py27,py34}) as references, that are needed to be replaced, which they are not.

    The patch simply amends regex which is used by Replacer to recognize references, to ignore factor arrays. And factor arrays assumed to be values, enclosed in curly braces, that contain at least one comma.

    → <<cset 66b0272bf19e>>

  2. Holger Krekel repo owner

    add changelog entry: fix issue302: allow cross-testenv substitution where we substitute with {x,y} generative syntax. Thanks Andrew Pashkin.

    → <<cset 581a1b974cd2>>

  3. Log in to comment