tox command busted on Windows

Issue #314 on hold
Henrik Skupin
created an issue

The tox command on Windows is busted due to the changes made by @Holger Krekel in https://bitbucket.org/hpk42/tox/commits/0823f359a05bde1d8f12f02e98b6b3a26d83c2b2

In detail it is this change:

  • newargs = [str(self.venv.getcommandpath())] + newargs
  • newargs = [str(self.envconfig.envpython)] + newargs

envconfig is not a property of the Action class, so changing it to the following will fix it:

newargs = [str(self.venv.envconfig.envpython)] + newargs

Here the traceback:

Traceback (most recent call last): File "c:\python27\lib\runpy.py", line 162, in _run_module_as_main "main", fname, loader, pkg_name) File "c:\python27\lib\runpy.py", line 72, in _run_code exec code in run_globals File "C:\Python27\Scripts\tox.exe__main__.py", line 9, in <module> File "c:\python27\lib\site-packages\tox\session.py", line 39, in main retcode = Session(config).runcommand() File "c:\python27\lib\site-packages\tox\session.py", line 375, in runcommand return self.subcommand_test() File "c:\python27\lib\site-packages\tox\session.py", line 548, in subcommand_test self.runtestenv(venv) File "c:\python27\lib\site-packages\tox\session.py", line 556, in runtestenv venv.test(redirect=redirect) File "c:\python27\lib\site-packages\tox\venv.py", line 332, in test ignore_ret=ignore_ret, testcommand=True) File "c:\python27\lib\site-packages\tox\venv.py", line 362, in _pcall redirect=redirect, ignore_ret=ignore_ret) File "c:\python27\lib\site-packages\tox\session.py", line 136, in popen stdout=stdout, stderr=STDOUT) File "c:\python27\lib\site-packages\tox\session.py", line 219, in _popen args = self._rewriteargs(cwd, args) File "c:\python27\lib\site-packages\tox\session.py", line 214, in _rewriteargs newargs = [str(self.envconfig.envpython)] + newargs AttributeError: 'Action' object has no attribute 'envconfig' Command exited with code 1

Comments (6)

  1. Log in to comment