Pull requests

#2 Open
Repository
msmhrt msmhrt
Branch
support-python3.3
Repository
hsoft hsoft
Branch
default

Modified some nodes to support Python 3.3

Bitbucket cannot automatically merge this request.

The commits that make up this pull request have been removed.

Bitbucket cannot automatically merge this request due to conflicts.

Review the conflicts on the Overview tab. You can then either decline the request or merge it manually on your local system using the following commands:

hg update default
hg pull -r support-python3.3 https://bitbucket.org/msmhrt/pyflakes3k
hg merge support-python3.3
hg commit -m 'Merged in msmhrt/pyflakes3k/support-python3.3 (pull request #2)'
Author
  1. Masami HIRATA
Reviewers
Description

Added TRY/YIELDFROM/WITHITEM nodes and deleted TRYEXCEPT/TRYFINALLY nodes

See: $ hg diff -r v3.2.3 -r v3.3.0 Python\Python-ast.c

  • Learn about pull requests

Comments (1)

  1. Virgil Dupras repo owner

    Could you please add automated tests for the feature?

    Also, it's not necessary to repeat the whole assignment in each if branch. I'm guessing that something like:

      if sys.version_info >= (3, 3):
          WITHITEM = handleChildren
    

    would be sufficient.