#2 Open
Repository
msmhrt msmhrt
Branch
support-python3.3
Repository
hsoft hsoft
Branch
default

Modified some nodes to support Python 3.3

Bitbucket cannot automatically merge this request due to conflicts.

Review the conflicts on the Overview tab. You can then either decline the request or merge it manually on your local system using the following commands:

hg update default
hg pull -r support-python3.3 https://bitbucket.org/msmhrt/pyflakes3k
hg merge support-python3.3
hg commit -m 'Merged in msmhrt/pyflakes3k/support-python3.3 (pull request #2)'
Author
  1. Masami HIRATA avatarMasami HIRATA
Reviewers
Description

Added TRY/YIELDFROM/WITHITEM nodes and deleted TRYEXCEPT/TRYFINALLY nodes

See: $ hg diff -r v3.2.3 -r v3.3.0 Python\Python-ast.c

Comments (1)

  1. Virgil Dupras repo owner

    Could you please add automated tests for the feature?

    Also, it's not necessary to repeat the whole assignment in each if branch. I'm guessing that something like:

      if sys.version_info >= (3, 3):
          WITHITEM = handleChildren
    

    would be sufficient.

Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.