PR unit tests

Issue #370 open
Benjamin Jakimow created an issue

automatically check PRs by running all EnMAP-Box unit tests

Comments (14)

  1. Benjamin Jakimow reporter

    because Bitbucket server will not become aware of local commits until they get pushed

  2. Andreas Janz

    I haven’t said anything about local commits.

    I wanted to know, if this is only related to pull requests (PR), or if this is also related to commits.

  3. Benjamin Jakimow reporter

    Ì don’t know if this is possible, but why do you want to start a pipeline for each commit (very uncommon) instead of push (which is the common case)?

  4. Andreas Janz

    Still not sure if we are talking about the same things here.

    Usually a CI pipeline is running after a commit is pushed to the repo. e.g.

    Are you saying, that the CI pipeline should only run after a PR (pull request)? We rarely use PRs, only a handful over the last years:

  5. Andreas Janz

    Benjamin, is it clear now, why I’m asking about the PRs?

    Having a CI pipeline would be great, but having it only for PRs would miss the point a bit.

  6. Benjamin Jakimow reporter

    To remove some misunderstandings:

    This issue is on implemented unit-tests pipelines that are triggered by pull requests (PR). The aim is to see if the PR will introduce failure in the code.

    We already run pipeline operations when changes are pushed to the remote repository. Details on that can be found in our bitbucket-pipelines.yml, https://support.atlassian.com/bitbucket-cloud/docs/build-test-and-deploy-with-pipelines/ (likely there are answers to all other questions related to pipeline in bitbucket).

    Like for push operations, PR usually contain a sets of changes, i.e. multiple commits. Neither ReadTheDocs nor our own pipeline is triggered by a single commit, but generally the set of changes, i.e. one or multiple commits, when they are pushed to the remote server (proof me wrong). As mentioned above (https://community.atlassian.com/t5/Bitbucket-questions/Can-I-trigger-Bitbucket-pipeline-with-pull-request/qaq-p/226236) “Normally the pipeline is triggered by push.

    As you asked for “Why not for each commit?”, without specifying local or remote, I assumed that you like to run the pipeline on each single commit (out of maybe hundreds provided by a push or PR), which, as mentioned above, would be very uncommon and I don’t really see the need for.

  7. Andreas Janz

    We already run pipeline operations when changes are pushed to the remote repository

    Thanks Benjamin, this is what I wanted to hear.

    And yes, you are right, a single push can contain multiple commits and the CI pipeline only runs agains the last commit.

  8. Log in to comment