`mlv_play` does not start properly from `file_man`

Issue #2044 resolved
Albert Shih created an issue

After commit be98a2a, trying to play a MLV file from file_man does not work. The problem code in mlv_play is:

static void mlv_play_set_mode(int32_t mode)
    /* comparing gui state with gui mode is generally not correct, but in this particular case, the values match */
    if (gui_state == mode)

From what I can tell, the bug is that the ML menu corresponds to GUI state 1, but that is not the same thing as GUI mode 1. Thus, bailing early and not calling SetGUIRequestMode is not correct.

Comments (1)

  1. Log in to comment