cr2hdr fails to build

Issue #2727 resolved
Daniel Fort created an issue

Compiling cr2hdr in the unified branch results in these errors:

cr2hdr.c:544:20: error: static declaration of 'module_get_string' follows
      non-static declaration
static const char* module_get_string(const char* name)
                   ^
./../../src/module.h:268:13: note: previous declaration is here
const char* module_get_string(int mod_number, const char* name);
            ^
cr2hdr.c:590:64: error: too few arguments to function call, expected 2, have 1
    printf("Last update: %s\n", module_get_string("Last update"));
                                ~~~~~~~~~~~~~~~~~              ^
./../../src/module.h:268:1: note: 'module_get_string' declared here
const char* module_get_string(int mod_number, const char* name);
^

-snip

cr2hdr.c:2574:21: error: function definition is not allowed here
                    {
                    ^
-snip-

10 warnings and 3 errors generated.
make: *** [cr2hdr] Error 1

Discussion: http://www.magiclantern.fm/forum/index.php?topic=15894.msg185460#msg185460

Stepping back through the commits I had to go all the way back to Pull Request #230 to find a version that built successfully. That doesn't seem quite right.

Comments (4)

  1. Log in to comment