ML AutoISO module, some small changes & fix compilation issues

#124 Declined
Repository
Marsu42
Branch
unified
Repository
Magic Lantern
Branch
unified
Author
  1. Marsu42
Reviewers

Comments (5)

  1. Marsu42 author

    Ok, since this hasn't been merged yet I added two modules, ml auto iso and a little helper module other might also find useful. Both need platform getter functions, I added a new src file for that. I also added a way for other modules to detect if ettr is active since it's mutually exclusive with ml auto iso.

  2. Giovanni Nanomad Condello

    I don't see the need of renaming everything, keep the old name as it's more clear and old ML users are familiar with it

    1. Marsu42 author

      What names - the variable names? ML users should never see them, only devs? I'd like the var names to be specific to the module (with a prefix) so it's crystal-clear what's from this module and what's from the core.

  3. Marsu42 author

    I'm declining this pull request myself because I don't see this getting merged, so why keep trying. It would be nice though to see an approved way to add model-specific functions that are required by modules to the ml core though, my approach with "module_glue.c" obviously wasn't it.

    1. Giovanni Nanomad Condello

      The main real issue I have is that everything in the module is prefixed m42 which seems a bit of a nonsense.

      Other than that, the glue idea is nice but I'm wondering if we can do something else instead