Bitbucket cannot automatically merge this request.
The commits that make up this pull request have been removed.
Bitbucket cannot automatically merge this request due to conflicts.
Review the conflicts on the Overview tab. You can then either decline the request or merge it manually on your local system using the following commands:
hg update 7a3b5fa3f4c6hg pull -r config_var_refactor https://bitbucket.org/dmilligan/magic-lantern# Note: This will create a new head!hg merge 2a7265dc39d4hg commit -m 'Merged in dmilligan/magic-lantern/config_var_refactor (pull request #420)'
The audio stuff is quite a mess and needs more refactoring than this, but I don't really have time or desire (I never use in camera audio, so what's in it for me?). Also, I have no way of testing the audio-lapis stuff so I don't even know if screwed something up. Probably needs some basic testing by someone with this camera before merging.
Anything else besides this that needs to do stuff when config vars change (needs a CBR)?
what is in it for me in this refactor?
Switch config presets w/o reboot
Decouple from menu API
Control with PTP
Easier to change settings from module or script
"Anything else besides this that needs to do stuff when config vars change (needs a CBR)?"
A few months ago I remember counting around 500 menu entries that need to be reviewed.