Restore after format: refactoring + fix for EOS-M

#575 Merged at a26bd28
Repository
Branch
restore-after-format
Repository
Branch
unified
Author
  1. Alex
Reviewers
Description

Issue https://bitbucket.org/hudson/magic-lantern/issue/2078/eos-m-cant-tap-to-switch-keep-ml-when

This used to work back then (1-2 years ago?), but lately it was broken for a loooooooong time and nobody noticed it. So, this looks like a good opportunity to check it on all other cameras.

=> please check the following:

  • whether you can toggle between "Format card, keep ML" and "Format card, remove ML"
  • whether you can still change stuff in Canon's format dialog (EOS-M uses the touchscreen for this, and it looks like there may be a better choice here)
  • whether the messages about "restoring file XX" are printed in the correct place (in Canon menu, in the same place as the Format menu entry)

TODO:

  • another known bug (and again, unreported) is that config presets will not be restored (because they are in subdirectories). To fix, we need to scan the ML directory recursively and not just some preset folders.
  • move this feature to a separate file?

Comments (14)

  1. nikfreak

    Looks good to me. Approved for 6D. I can:

    1. toggle between "Format card, keep ML" and "Format card, remove ML" by pressing [Q]
    2. change stuff like Low level" format by pressing delete / trash button. cancel option works, erase, too
    3. When using "Format card, keep ML" and confirming with "erase" the messages about "restoring file XX" are printed in the correct place (in Canon menu, in the same place as the Format menu entry)

    Sum it up: Working fine on 6D.

  2. Alex author

    Good. Will wait until the constants will be confirmed on all other cameras (so far 6D, 700D and EOS-M were confirmed).

    If I'll get tired of waiting, I'll break the builds for which I don't have a confirmation.

    1. escho
      Restore after format: refactoring + fix for EOS-M 
      

      If you want this to be tested on all cameras, it would be nice, if you mark this issue valid for all cameras in the headline too. Since I don´t use a EOS-M, it was a coincidence, that I came reading into this thread

    1. Alex author

      Can you try with BGMT_Q_ALT on 1100D? If not, try to print the event codes from Debug menu, and see what button code you get for Q when the format dialog is displayed.

  3. escho

    600D: Cannot toggle between the options (Q)

    messages are on the right place, I guess (in the format-line)

    I can enable and disable lowlevel-format