This method uses the patch manager to apply the same modification to LiveViewApp that was used for most DIGIC 4 cameras. Before, this function was relocated to RAM and patched there, but the method did not work on DIGIC 5 cameras (don't remember exactly why; probably the code was more complex than the relocation routine could handle).
It should fix the following issues:
60D err80 with the RscMgr_memory branch (the reloc method relies on short jumps, so the relocated code must be placed at very low addresses, not in RscMgr)
650D/700D crash when processing raw images in camera (issue #2434); it looks like overriding DebugMsg causes that issue, no idea why, but...
So, the DebugMsg hack is no longer required for the bottom bar. It's still enabled on 5D3 and 6D for other purposes (ADTG shutter speed controls for FPS override, and - on 5D3 - a workaround for some troublesome CF cards).
Note: EOS M needs a new stub (LiveViewApp_handler_BL_JudgeBottomInfoDispTimerState). 650D, 700D and 6D already have it, but may have to be checked again, as it was not used for anything else.
TBD on 70D and 100D as well.
I'd still like to get a version that doesn't require ROM patching, but so far, this method seems to be the best compromise.
On 70D this doesn't work. Fixed the handler stubs (compared to 5D3) but after trying it out the camera does only show a blackscreen when in LV/MV. In photo mode it's ok. But more annoying is that even with or w/o fixing the handler stub the camera won't power off. It will shut down when switching power button to off position but if you press a button (e.g. shutter button) camera will indicate some continous led for about a second. Need to take battery out.
Going to try on SL1 too.
If you uncomment CONFIG_LVAPP_HACK_PATCH, do you get clean shutdown?
Same question, if you uncomment only the two patch/unpatch calls from liveview.c.
When uncommenting CONFIG_LVAPP_HACK_PATCH everything is ok. No shutdown bug.
Additionally 100d is fine with this PR.
We got a conversation lately where you asked me to hg bisect. Running it pointed me some things. Might have f'd up my 70D branch and maybe that might also be the reason why we got 2 ppl lately with problems?