Raw image capture metadata (pixel binning/skipping, sensor offsets) for MLV

#827 Merged at 02f01f0
Repository
Branch
raw_capture_info
Repository
Branch
unified
Author
  1. Alex
Reviewers
Description
  • Cherry-picked from crop_rec branch
  • Was discussed here and here
  • Modules are allowed to override raw_info and raw_capture_info from CBR_RAW_INFO_UPDATE (which is called on raw_update_params)
  • Crop factor display in MLV recorders uses this metadata

Changes from crop_rec_version:

  • Duplicated the structure fields (so our structure is allowed to change later without breaking the file format)
  • Fix line skipping info for EOS M (not tested; it was incorrect in the crop_rec branch)
  • Fine-tuned the definition of offsets (which are not used yet; just defined for future use)

Comments (6)

  1. Daniel Fort

    Tried it out on the EOS M. MLV and MLV Lite using various settings look good. Is there any test you'd like me to run to check on the line skipping info?

    1. Alex author

      Just make sure the metadata actually matches the video modes. On 700D, with 1080p in Canon menu, it should report 3x3 (with line skipping), while on M it should report 5x3 (also with skipping).

      1. Daniel Fort

        OK--that would require mlv_dump from this branch. I'm getting errors when trying to build it:

        mlv_dump.c:1054:15: error: no member named 'raw_capture_info' in
              'mlv_rawc_hdr_t'
                rawc->raw_capture_info.sensor_res_x,
                ~~~~  ^
        mlv_dump.c:1055:15: error: no member named 'raw_capture_info' in
              'mlv_rawc_hdr_t'
                rawc->raw_capture_info.sensor_res_y
                ~~~~  ^
        mlv_dump.c:1059:15: error: no member named 'raw_capture_info' in
              'mlv_rawc_hdr_t'
                rawc->raw_capture_info.sensor_crop / 100,
                ~~~~  ^
        

        etc...