1. Trammell Hudson
  2. Untitled project
  3. Magic Lantern
  4. Pull requests

Raw fixes part 5

#828 Merged at 0752dd8
Repository
Branch
raw_fixes
Repository
Branch
unified
Author
  1. Alex
Reviewers
Description

Cherry-picked from crop_rec_4k.

There are some more, but they depend on raw_capture_info. Will add another series after merging that.

For testing, it's probably best to confirm each issue in unified, then check whether it was fixed in this branch.

TODO:

  • exact height for cameras with focus pixels (IIRC there are some issues with MLVFS)
  • port the mlv_lite changes to mlv_rec if desired

Comments (3)

  1. DeafEyeJedi

    Trying to wrap my head around the 'to do' list especially w cameras that have focus pixels, I feel like we're wasting your time by not generating valuable feedbacks in here and any hints would be appreciated.

    1. Alex author

      You are probably interested in this paragraph, not in the coding TODOs:

      For testing, it's probably best to confirm each issue in unified, then check whether it was fixed in this branch.

      Refer to each commit message for details.

  2. Daniel Fort

    Just a note on the todo list.

    • exact height for cameras with focus pixels (IIRC there are some issues with MLVFS)

    Looking through my notes it seems that this issue came up around the time Raw fixes part 3 was merged. (pull request #778) I didn't notice it at first because it wasn't consistent but it does seem that the vertical resolution can vary by 1 pixel after these changes. Not sure exactly what caused it. @Danne fixed my focus pixel script to allow for a little bit of slop but since MLVFS identifies the focus pixel map files by their file names which contains the exact size of the full raw buffer, it has a problem when the size varies.

    It seems that this only affects the vertical resolution and the map files still work if renamed so the focus pixel coordinates do not move.