Commits

Kevin Hunter committed 8fd582f Draft

Mild cleanup

Remove individual ifs in favor of a loop construct. It's mildly
more extensible.

Comments (0)

Files changed (1)

sphinx/ext/graphviz.py

         node = graphviz()
         node['code'] = dotcode
         node['options'] = []
-        if 'align' in self.options:
-            node['align'] = self.options['align']
-        if 'alt' in self.options:
-            node['alt'] = self.options['alt']
-        if 'caption' in self.options:
-            node['caption'] = self.options['caption']
-        node['inline'] = 'inline' in self.options
+        for i in ('align', 'alt', 'caption'):
+            if i in self.options:
+                node[ i ] = self.options[ i ]
+        for i in ('inline',):
+            node[i] = i in self.options
         return [node]
 
 
         node['code'] = '%s %s {\n%s\n}\n' % \
                        (self.name, self.arguments[0], '\n'.join(self.content))
         node['options'] = []
-        if 'align' in self.options:
-            node['align'] = self.options['align']
-        if 'alt' in self.options:
-            node['alt'] = self.options['alt']
-        if 'caption' in self.options:
-            node['caption'] = self.options['caption']
-        node['inline'] = 'inline' in self.options
+        for i in ('align', 'alt', 'caption'):
+            if i in self.options:
+                node[ i ] = self.options[ i ]
+        for i in ('inline',):
+            node[i] = i in self.options
         return [node]
 
 
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.