ROCm header deprecation warnings for ROCm5.2+

Issue #63 resolved
Nair, Jithun created an issue

We see the following deprecation warnings from magma headers when building PyTorch with ROCm5.2 or above. This is because the ROCm component headers are being added to a standardized location “/opt/rocm<blah>/include/<component>", where componentin this case would be either hipsparseor hipblas.

In file included from /opt/rocm/magma/include/magma_types.h:148,
from /data/pytorch/aten/src/ATen/native/hip/linalg/MagmaUtils.h:6,
from /data/pytorch/aten/src/ATen/native/hip/linalg/BatchLinearAlgebra.cpp:20:
/opt/rocm-5.2.0/include/hipblas.h:16:160: note: #pragma message: : warning : This file is deprecated. Use the header file from /opt/rocm-5.2.0/include/hipblas/hipblas.h by using #include <hipblas/hipblas.h>
16 | #pragma message(": warning : This file is deprecated. Use the header file from /opt/rocm-5.2.0/include/hipblas/hipblas.h by using #include <hipblas/hipblas.h>")
| ^
In file included from /opt/rocm/magma/include/magma_types.h:149,
from /data/pytorch/aten/src/ATen/native/hip/linalg/MagmaUtils.h:6,
from /data/pytorch/aten/src/ATen/native/hip/linalg/BatchLinearAlgebra.cpp:20:
/opt/rocm/hipsparse/include/hipsparse.h:16:168: note: #pragma message: : warning : This file is deprecated. Use the header file from /opt/rocm-5.2.0/include/hipsparse/hipsparse.h by using #include <hipsparse/hipsparse.h>
16 | #pragma message(": warning : This file is deprecated. Use the header file from /opt/rocm-5.2.0/include/hipsparse/hipsparse.h by using #include <hipsparse/hipsparse.h>")
| ^

The fix needs to be in places such as https://bitbucket.org/icl/magma/src/52200a1fc0e0f77a5c4b507e0328f1a05bccf1ec/make.inc-examples/make.inc.hip-gcc-mkl#lines-146. Maybe the lib paths should be updated as well, since they are all present in “/opt/rocm<blah>/lib/" as well.

Comments (2)

  1. Log in to comment