Unneeded NULL pointer checks in sde component

When compiling the code the current papi repository as an RPM there were several checks in the SDE component that the compiler points out as will always be false because buckets is an array in the cset_hash_table_s struct:

typedef struct cset_hash_table_s {
    cset_hash_bucket_t buckets[_SDE_HASH_BUCKET_COUNT_];
    cset_list_object_t *overflow_list;
} cset_hash_table_t;

Below are the compiler warning for compileing the sde_lib_datastructures.c:

sde_lib_datastructures.c: In function 'cset_insert_elem':
sde_lib_datastructures.c:231:34: warning: the comparison will always evaluate as 'false' for the address of 'buckets' will never be NULL [-Waddress]
  231 |     if( NULL == hash_ptr || NULL == hash_ptr->buckets ){
      |                                  ^~
In file included from sde_lib_datastructures.c:13:
sde_lib_internal.h:82:24: note: 'buckets' declared here
   82 |     cset_hash_bucket_t buckets[_SDE_HASH_BUCKET_COUNT_];
      |                        ^~~~~~~
sde_lib_datastructures.c: In function 'cset_remove_elem':
sde_lib_datastructures.c:331:34: warning: the comparison will always evaluate as 'false' for the address of 'buckets' will never be NULL [-Waddress]
  331 |     if( NULL == hash_ptr || NULL == hash_ptr->buckets ){
      |                                  ^~
sde_lib_internal.h:82:24: note: 'buckets' declared here
   82 |     cset_hash_bucket_t buckets[_SDE_HASH_BUCKET_COUNT_];
      |                        ^~~~~~~
sde_lib_datastructures.c: In function 'cset_to_list':
sde_lib_datastructures.c:422:34: warning: the comparison will always evaluate as 'false' for the address of 'buckets' will never be NULL [-Waddress]
  422 |     if( NULL == hash_ptr || NULL == hash_ptr->buckets ){
      |                                  ^~
sde_lib_internal.h:82:24: note: 'buckets' declared here
   82 |     cset_hash_bucket_t buckets[_SDE_HASH_BUCKET_COUNT_];
      |                        ^~~~~~~
sde_lib_datastructures.c: In function 'cset_delete':
sde_lib_datastructures.c:471:34: warning: the comparison will always evaluate as 'false' for the address of 'buckets' will never be NULL [-Waddress]
  471 |     if( NULL == hash_ptr || NULL == hash_ptr->buckets ){
      |                                  ^~
sde_lib_internal.h:82:24: note: 'buckets' declared here
   82 |     cset_hash_bucket_t buckets[_SDE_HASH_BUCKET_COUNT_];
      |                        ^~~~~~~
Installation MANDIR : /usr/share/man

‌

Comments (1)