1. ICL
  2. PLASMA
  3. plasma
  4. Pull requests

Pull requests

#31 Declined
Repository
mabalenk
Branch
fortran
Repository
icl
Branch
default

PLASMA Fortran interface and examples

Author
  1. Maxim Abalenkov
Reviewers
Description
No description

Comments (2)

  1. Jakub Kurzak

    Some quick observations:

    Is there really a good reason for the directory structure? If the Fortran interface is a first class citizen, the mod files can go in /include/. Any reason not to?

    My understanding is that they are auto-generated. If so, why commit them to the repository? Generate them at compile time.

    "examples/test_" - so, are they tests of examples? If examples, remove the "test_" prefix. If tests, don't name the folder "examples". Also, why would you commit all precisions? Precision should be auto generated.

    Lastly, remove the conflict in control/context.c, PLZ.

  2. Jakub Sistek

    Thanks for the feedback.

    The mod files are copied to /include/ as part of the build process. Not all of the plasma_*mod.f90 files are autogenerated - only those for plasma{z,d,c,s,zc,ds}.h. On the other hand, plasma_types_mod.f90, plasma_control_mid.f90 and the plasma_mod.f90 are hand-written for better legibility.

    Precisions of examples are now auto generated from the complex case by codegen.py.