#33 Declined
Repository
plasma_lua_variadic
Branch
default
Repository
plasma
Branch
default
Author
  1. Negin Bagherpour
Reviewers
Description
  • adding call to tuning for all kernels with the variadic format, compeleting the default lua and update of tuning file.

Hi

So, please see (dd4e411).

Best, Negin

Comments (2)

  1. Jakub Kurzak

    There are some problems.

    zgemm.c has this:

    // tune parameters
        if (plasma->tuning)
            plasma_tune_gemm(plasma, PlasmaComplexDouble, m, n, k);
        // Set tiling parameters.
        int nb = plasma->nb;
    

    zgetrf.c has this:

        // Tune parameters.
        if (plasma->tuning)
             plasma_tune_getrf(plasma, PlasmaComplexDouble, m, n);
    
        int nb = plasma->nb;
    

    zpotrf has this:

    // tune parameters
        if (plasma->tuning)
            plasma_tune_potrf(plasma,PlasmaComplexDouble, n);
        // Set tiling parameters.
        int nb = plasma->nb;
    

    Please be consistent with indentation, whitespace and comments.

    tuning.c and default.lua:

    potrf and gemm don't have panel factorizations like LU. Therefore, there's no gemm_max_panel_threads or potrf_max_panel_threads.

  2. Jakub Kurzak

    Also, when we have a list of functions that look alike, we try to stick to alphabetical order. I.e., please have the following order in tuning.c:

    • plasma_tune_gemm
    • plasma_tune_getrf
    • plasma_tune_potrf

    Similar for default.lua.