Ian Cordasco avatar Ian Cordasco committed 2925386

Fix a consistency issue.

Comments (0)

Files changed (2)

 
   - is_active() and active return the same value
 
+- In github3.pulls.PullRequest
+
+  - is_mergeable() and mergeable are now the same
+
 - Some objects now have ``__str__`` methods. You can now do things like:
 
   ::
         # If the pull request has been merged
         if self.merged_at:
             self.merged_at = self._strptime(self.merged_at)
-        self._mergeable = pull.get('mergeable')
+        self.mergeable = pull.get('mergeable', False)
         #: :class:`User <github3.users.User>` who merged this pull
         self.merged_by = pull.get('merged_by')
         if self.merged_by:
 
         :returns: bool
         """
-        return False if self._mergeable is None else self._mergeable
+        return self.mergeable
 
     def is_merged(self):
         """Checks to see if the pull request was merged.
             data = {'commit_message': commit_message}
         url = self._build_url('merge', base_url=self._api)
         resp = self._put(url, data)
+        self.merge_commit_sha = resp['merge_commit_sha']
         return resp.json['merged']
 
     @requires_auth
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.