1. ignitionrobotics
  2. Ignition
  3. ign-transport
  4. Pull requests

Pull requests

#151 Merged at f731f62
Repository
nampi
Branch
issue_45_tmp
Repository
ignitionrobotics
Branch
default

Issue_45: Service requests without input parameter

Author
  1. nampi
Reviewers
Description

Adding opportunity to define server without input parameter, create request and asynchronous request to this server. We could use the msgs::Empty for not having to modify the wire format when sending a service request.

There are three new examples with new feature.

Adding tests and integration tests.

Comments (12)

    1. nampi author

      Do you mean to rename only these three files examples/requester_no_input.cc, examples/requester_async_no_input.cc, examples/responser_no_input.cc or also rename all other files and functions inside them?

  1. Carlos Agüero

    Test results:

    • Ubuntu Trusty :large_blue_circle:
    • Windows :large_blue_circle: (except for the unrelated Jenkins warning). Nothing to do here.
    • Homebrew 🔶 There are three warnings. You can just comment in line _internalReq. E.g.:
    std::function<void(const msgs::Empty &, T &, bool &)> f =
      [_cb, _obj](const msgs::Empty &/*_internalReq*/, T &_internalRep,
                        bool &_internalResult)
    {
      auto cb = std::bind(_cb, _obj, std::placeholders::_1,
        std::placeholders::_2);
      cb(_internalRep, _internalResult);
    };