1. ignitionrobotics
  2. Ignition
  3. ign-transport
  4. Pull requests

Pull requests

#154 Merged at cbbb439
Repository
amtj
Branch
staging
Repository
ignitionrobotics
Branch
ign-transport2

Service requests without response

Author
  1. Amitoj
Reviewers
Description

Not all the service requests require a response. We'd add some logic for removing the service request handler after sending the request, instead of waiting for the response. We could use the msgs::Empty for not having to modify the wire format when sending a service request. We'd create a new Request function in the Node class with only one parameter (the input parameter).

Two examples are included SrvProviderOneway and RequesterOneway.

Integration tests are also added.

Comments (28)

  1. Carlos Agüero

    The following tests fail for me on Ubuntu (I haven't tried MAC OS X or Windows yet):

    5 tests, listed below:
    [  FAILED  ] NodeTest.ClassMemberCallbackServiceWithoutOutput
    [  FAILED  ] NodeTest.ServiceWithoutOutputCallAsync
    [  FAILED  ] NodeTest.ServiceCallWithoutOutputAsyncLambda
    [  FAILED  ] NodeTest.MultipleServiceWithoutOutputCallAsync
    [  FAILED  ] NodeTest.ServiceWithoutOutputCallSync
    
  2. Carlos Agüero

    The style checker shows two warnings:

    caguero@bb9:~/workspace/ign-transport_amtj$ sh tools/code_check.sh 
    [src/Node_TEST.cc:800]: (style) Variable 'advCb' is assigned a value that is never used.
    [src/Node_TEST.cc:810]: (style) Variable 'reqCb' is assigned a value that is never used.
    
  3. Carlos Agüero

    Amitoj Hanspal, could you create a separate pull request for documenting your changes in the tutorials? It should go in the "Using services" section of the documentation. Please, target the new pull request to ign-transport2 branch.

  4. Carlos Agüero

    Also, do you mind answering all comments to make sure that all the feedback has been addressed? Ideally, with the commit that solves the suggestion. It's a little bit of extra work but much more convenient for the reviewers.

  5. Carlos Agüero

    The new examples don't compile. See my suggestions below. For the future, make sure that the library and all examples compile, all tests pass and the new examples work before submitting the pull request. I know there are lots of things to check but you'll catch all the problems faster :)