License clarification

[Orion Poplawski]

License for jaudiotagger is listed as LGPLv2+, but many source files are missing copyright headers. It would be good to get this fixed.

Also at issue, some files have copyright but no license, e.g.:

jaudiotagger/src/org/jaudiotagger/audio/exceptions/InvalidAudioFrameException.java jaudiotagger/src/org/jaudiotagger/audio/mp3/MPEGFrameHeader.java

• Jaikoz Copyright Copyright (C) 2003 -2005 JThink Ltd

Most troublesome though is the src/org/jaudiotagger/utils/tree/ code, which is:

• Copyright (c) 2006, Oracle and/or its affiliates. All rights reserved.
• ORACLE PROPRIETARY/CONFIDENTIAL. Use is subject to license terms.

I understand that some swing code was copied for android support, but I'm not sure that this is acceptable. Also, for Fedora packaging, we would very much prefer to build against the system swing code.

[IJabz]

Okay so the license is meant to be LGPL v2. Ive never seen the real need to put the license information in every single file as it clearly states it in the license.txt but if you want to do that please do a pull request. However note I also have an ongoing request to change to a more relaxed license https://bitbucket.org/ijabz/jaudiotagger/issues/2/add-apache-license but to do that I need to track down some of the other contributors.

Regarding the code in src/org/jaudiotagger/utils/tree/ code If forgotten about this but it is a basterdized version of Treemodel for the purposes of supporting the (non-binary) tree model use by the mp4 structure, its nothing to do with Gui whatsoever I just couldn't find a suitable tree model other than the one used by Swing at the time. Perhaps there is an alternative in Guava or something, perhaps I can just change the license for these files. Because we arent using the tree model for its intended use (as part of GUI) I dont feel the code needs to be built against the latest java Swing libs there is no particular advantage in doing that.

What I don't want to do is split the project into two projects (Android , non-android)

[Orion Poplawski]

The only truly definitive source for the license of a file is in the file itself. Separate the file from the project and you no longer have a clear license for it (case in point - the copied swing files). I'll see if I can put together a PR, but there should be tools to do this pretty easily.

You are not the author the swing code so you can't just change the license of it, and it seems highly likely that you can't make use of it unless you can figure out what the license is. I would suggest trying to find a replacement.