Problems when writing massive (16MB) images into FLACs

Just seen this with the following cover art: http://coverartarchive.org/release/8cf6f9e0-9a9b-4b3c-a130-2f79b813eaf7/2484412065.jpg . 16MB!

Here's a fairly self contained snippet. You'll have to change the FLAC file location, I guess:

public class JaudioTaggerMassiveArtTest {

private static final File FLAC_FILE = new File("/tmp/small.flac");

@Before public void addLargeArt() throws Exception {

    final URL artUrl = new URL("http://coverartarchive.org/release/8cf6f9e0-9a9b-4b3c-a130-2f79b813eaf7/2484412065.jpg");
    ReadableByteChannel rbc = Channels.newChannel(artUrl.openStream());
    final File imageFile = new File("/tmp/massive_image.jpg");
    FileOutputStream fos = new FileOutputStream(imageFile);
    fos.getChannel().transferFrom(rbc, 0, 1 << 24);

    AudioFile f = AudioFileIO.read(FLAC_FILE);
    Tag tag = getTag(f);
    tag.setField(StandardArtwork.createArtworkFromFile(imageFile));
    f.commit();
}

protected Tag getTag() throws Exception {
    return getTag(AudioFileIO.read(FLAC_FILE));
}

protected Tag getTag(AudioFile f) throws Exception {
    return f.getTag();
}


@Test public void canReadImage() throws Exception {
    final List<Artwork> artworkList = getTag().getArtworkList();
    assertEquals(1, artworkList.size());
}

}

When I run that, I get:

21-Feb-2013 17:34:55 org.jaudiotagger.audio.generic.AudioFileReader read
SEVERE: File /tmp/small.flac being read
java.nio.BufferUnderflowException
    at java.nio.HeapByteBuffer.get(HeapByteBuffer.java:145)
    at java.nio.ByteBuffer.get(ByteBuffer.java:692)
    at org.jaudiotagger.audio.flac.metadatablock.MetadataBlockDataPicture.initFromByteBuffer(MetadataBlockDataPicture.java:91)
    at org.jaudiotagger.audio.flac.metadatablock.MetadataBlockDataPicture.<init>(MetadataBlockDataPicture.java:126)
    at org.jaudiotagger.audio.flac.FlacTagReader.read(FlacTagReader.java:90)
    at org.jaudiotagger.audio.flac.FlacFileReader.getTag(FlacFileReader.java:45)
    at org.jaudiotagger.audio.generic.AudioFileReader.read(AudioFileReader.java:106)
    at org.jaudiotagger.audio.AudioFileIO.readFile(AudioFileIO.java:286)
    at org.jaudiotagger.audio.AudioFileIO.read(AudioFileIO.java:150)
    at com.elsten.bliss.platform.storage.file.jaudiotagger.test.JaudioTaggerMassiveArtTest.getTag(JaudioTaggerMassiveArtTest.java:39)
    at com.elsten.bliss.platform.storage.file.jaudiotagger.test.JaudioTaggerMassiveArtTest.canReadImage(JaudioTaggerMassiveArtTest.java:48)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:616)
    at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
    at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
    at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
    at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
    at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
    at org.junit.runners.BlockJUnit4ClassRunner.runNotIgnored(BlockJUnit4ClassRunner.java:79)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:71)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:49)
    at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
    at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
    at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
    at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
    at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
    at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
    at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:50)
    at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
    at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
    at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
    at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
    at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)

I think this will become more of a problem with time as artwork grows in size.

Comments (2)