Make changes so library can be used on Android.

Declined
#46 · Created  · Last updated

Declined pull request

Things have moved and you have your own fork.

Closed by: ·2021-10-08

Description

  1. In the AudioFileReader2 hierarchy, remove the usage of java.nio.file.Path, java.nio.file.Files

  2. Remove FileTime usage and getting/setting the file creation date. Comment out tests related to this

  3. Comment out Permissions because it uses Path and things such as AclFileAttributeView, which aren't supported

This removes the setting/getting file creation from jaudiotagger and displaying the detailed file permissions information in logging/exceptions when there is a failure.

With these changes, all jaudiotagger functionality is available on Android, minus the features just mentioned.

All tests pass, less commented out tests related to file creation time and a test that unrelated to any changes I made. AsfHeaderUtils.testConversionDateConstant

I merged the main branch into this branch minutes ago.

I'm unsure of the need for setting the file creation timestamp, but realize it may prevent this merge. I don't need it and other Android developers may not either. This was 1 days work, so some more thought given to design might give a solution for including these methods. Till that happens, developers can pull this branch. I really don't have more time than this to dedicate at the moment.

Sorry about the IntelliJ fu. I thought I'd excluded those files.

0 attachments

0 comments

Loading commits...