1. David Jean Louis
  2. django-admin-tools
  3. Issues
Issue #62 resolved

part for displaying messages of dashboard/templates/admin/base.html does not match admin/base.html of django.contrib.admin

Steffen Jasper
created an issue

dashboard/templates/admin/base.html (lines 60-62):

{{{

!python

{% if messages %} <ul class="messagelist">{% for message in messages %} <li>{{ message }}</li> {% endfor %}</ul> {% endif %} }}}

admin/base.html (lines 58-62, current Django 1.2.3):

{{{

!python

{% if messages %} <ul class="messagelist">{% for message in messages %} <li{% if message.tags %} class="{{ message.tags }}"{% endif %}>{{ message }}</li> {% endfor %}</ul> {% endif %} }}}

Comments (5)

  1. Steffen Jasper reporter

    I have not tested it, but I think the part

    {% if message.tags %} class="{{ message.tags }}"{% endif %}
    

    should fail silently under Django 1.1, because there a message has no attribute tags. The if clause will evaluate to wrong an the whole part is not added to the output. In the end, under Django 1.1 the output will be the same as before. Anything missing in my assumption?

    Greetings, leture

  2. Log in to comment