memory leak in Compare::EventTree()

[Jochem Snuverink]

Coverity reports a memory leak in Compare::EventTree()

Code simplified:

  for (auto i = 0; i < t1->GetEntries(); i++)
    {
      ResultEvent* re = new ResultEvent();
      ...
      ret->eventResults.push_back(*re);
      ...
    }

re is copied in the push_back and leaked at the end of the loop.

An easy solution would be to make eventResults vector hold pointers, and delete them in the destructor of ResultEventTree. This avoids the copy and uses pointers in the container (generally advisable).

[Laurie Nevay]

Should be fixed now with commit #241b69f