Reference ROOT files in tests out of date

Issue #75 resolved
Jochem Snuverink created an issue

Due to the fix of issue #69, the reference ROOT files are out of date and need to be replaced.

Comments (7)

  1. Laurie Nevay

    Do we need the small section of beam pipe at the beginning of all the closed collimator examples? It makes it harder to correlate the boundaries. I haven't changed them as it involves updating all the reference histograms. Just wondered if there was a specific reason.

  2. Jochem Snuverink reporter

    Right now is the time to update those tests if so wished since now the ROOT files are out of date in any case. In the viewer I think it is nice to have a little bit of drift before to see the particle smash into the collimator, but I don't have a big preference.

  3. Jochem Snuverink reporter

    I have updated the text files to reflect the change in sampler name. The reference ROOT files still need updating.

  4. Jochem Snuverink reporter

    Now that the default output test format is rootevent, these jobs no longer provide the right output name and format.

  5. Laurie Nevay

    We should keep them just now rather than delete them early so we have a comparison when we make new ones.

    The comparison program Stewart wrote (I propose we call it "comparator") needs to be updated for the output from rebdsim. He agreed to work on this at last meeting. This issue is already assigned to him, but once this is done, we can all go through and start making the histograms together. This will be completed for V1.0, but no V0.93.

  6. Jochem Snuverink reporter

    Up to fairly recently the COMPARE tests were successful again, but now they fail with:

    #!
    Comparison of "optics" of type TTree(optics) Failed
    File (1/2) entries (1/0)
    Offending branches: Sigma_Emitt_x Sigma_Emitt_y Sigma_Alpha_x Sigma_Alpha_y Sigma_Beta_x Sigma_Beta_y Sigma_Gamma_x Sigma_Gamma_y Sigma_Disp_x Sigma_Disp_y Sigma_Disp_xp Sigma_Disp_yp Sigma_Mean_x Sigma_Mean_y Sigma_Sigma_x Sigma_Sigma_y Sigma_Sigma_xp Sigma_Sigma_yp Sigma_Mean_E Sigma_Mean_t Sigma_Sigma_E Sigma_Sigma_t 
    
  7. Laurie Nevay

    I've now updated all the tests and output reference files. Since this issue was originally posted, we've changed the structure of the output files and analysis output files. The comparator program was written and now works on these files. The test macros and input test were revised to be clearer.

  8. Log in to comment