Nether gas constant repopulation

Issue #39 resolved
Zero_ ui9 created an issue

In the latest version of glen's gases(1.6.3) there seems to be a bug where if you get rid of a gas cloud in the nether, or potentially if you dig a room, then leave and come back, the chunks will repopulate with the gases in the exact same positions every time(or in the case of having dug a room, gas will appear since its now a valid place to generate). This does not happen on logging out/in, but from traveling away from the chunk and coming back.

Having just removed a gas cloud then leaving/coming back, you can see the turquoise dust on the ground despite the gas cloud looking like it hadn't been touched: gas1.jpg

Having dug out a room, then coming back to find corrosive gas appear in the center of it: gas2.jpg

Comments (8)

  1. Trent VanSlyke

    Before I start investigating: do you have gas regeneration enabled in the config? I believe it's labelled as retrogen.

  2. Zero_ ui9 reporter

    ah, that would be correct. retrogen { # If true, retrogen will be enabled for only the next Minecraft session. This field will automatically reset to its default value. Consult the information database for more information B:Enable=true

    However, I'm now assuming that "true" is the default, as I have never touched this config, and my game has definitely been launched multiple times.(it should default to false?)

  3. Erlend Åmdal repo owner

    The expected behaviour is defaulting to false and automatically resetting to false. This part of the configurations has been unchanged for a long time, so I find it strange that this issue would suddenly emerge.

    Here are two things I'd like you try out:

    • Completely remove the retrogen entry from the configuration file, launch the game, then check the configuration file. The entry should re-appear as false.

    • Set the retrogen entry in the configuration file to false, launch the game, then check the configuration file. The entry should remain false.

    Even if this is a problem with the configuration file, it's still not behaving as intended. Gases Framework stores which gases have been generated in the chunk data, and should not retro-generate any of those gases.

  4. Zero_ ui9 reporter

    The config still defaulted to true in both cases. I also uninstalled it, deleted all the config files, redownloaded it and the default was still true.

  5. Erlend Åmdal repo owner

    Great work! After having a quick look I can confirm there is in fact a problem with the configurations which will set all auto-reset values to true instead of its default value. I am ashamed this would go unnoticed.

    Since there is another mechanism that should have prevented this, I'll look further for issues with the retrogen code.

    I should be able to push out a fix to CurseForge fairly quickly.

  6. Log in to comment