1. Jason R. Coombs
  2. cpython-issue13772

Commits

Jason R. Coombs  committed abfe76a

Issue #13211: Add .reason attribute to HTTPError to implement parent class (URLError) interface.

  • Participants
  • Parent commits 0e2812b
  • Branches 3.2

Comments (0)

Files changed (2)

File Lib/test/test_urllib2.py

View file
  • Ignore whitespace
         req = Request(url)
         self.assertEqual(req.get_full_url(), url)
 
+def test_HTTPError_interface():
+    """
+    Issue 13211 reveals that HTTPError didn't implement the URLError
+    interface even though HTTPError is a subclass of URLError.
+
+    >>> err = urllib.error.HTTPError(msg='something bad happened', url=None, code=None, hdrs=None, fp=None)
+    >>> assert hasattr(err, 'reason')
+    >>> err.reason
+    'something bad happened'
+    """
+
 def test_main(verbose=None):
     from test import test_urllib2
     support.run_doctest(test_urllib2, verbose)

File Lib/urllib/error.py

View file
  • Ignore whitespace
     def __str__(self):
         return 'HTTP Error %s: %s' % (self.code, self.msg)
 
+    # since URLError specifies a .reason attribute, HTTPError should also
+    #  provide this attribute. See issue13211 for discussion.
+    @property
+    def reason(self):
+        return self.msg
+
 # exception raised when downloaded size does not match content-length
 class ContentTooShortError(URLError):
     def __init__(self, message, content):