Commits

jrosdahl  committed bb7f7d3

Improved comment about arguments to
ircbot.SingleServerIRCBot._on_namreply. Patch from Jeff Huang.

Renamed has_message_from_outside_protection to
has_allow_external_messages. Patch from Jeff Huang.

  • Participants
  • Parent commits c18e31d

Comments (0)

Files changed (2)

 2005-01-17  Joel Rosdahl  <joel@rosdahl.net>
 
+	* ircbot.py (SingleServerIRCBot._on_namreply): Improved comment
+	about arguments to the function. Patch from Jeff Huang.
+	(Channel.has_allow_external_messages): Renamed from
+	has_message_from_outside_protection. Patch from Jeff Huang.
+
 	* irclib.py (ServerConnection.quit): Added comment about how some
 	IRC servers' treat QUIT messages. Patch from Jeff Huang.
 
     def _on_namreply(self, c, e):
         """[Internal]"""
 
-        # e.arguments()[0] == "="     (why?)
+        # e.arguments()[0] == "@" for secret channels,
+        #                     "*" for private channels,
+        #                     "=" for others (public channels)
         # e.arguments()[1] == channel
         # e.arguments()[2] == nick list
 
     def is_invite_only(self):
         return self.has_mode("i")
 
-    def has_message_from_outside_protection(self):
-        # Eh... What should it be called, really?
+    def has_allow_external_messages(self):
         return self.has_mode("n")
 
     def has_limit(self):