Commits

Author Commit Message Labels Comments Date
ja...@cda61777-01e9-0310-a592-d414129be87e
New FAQ: "When I put PuTTY in C:\WINDOWS\SYSTEM32 on my 64-bit Windows system, `Duplicate Session' doesn't work." (Explanation courtesy Owen.)
ja...@cda61777-01e9-0310-a592-d414129be87e
It's a new year.
si...@cda61777-01e9-0310-a592-d414129be87e
If we're called on to uncleanly close an SSH channel for which we've already sent SSH2_MSG_CHANNEL_CLOSE, we should not skip the _whole_ of sshfwd_unclean_close(), only the part about sending SSH2_MSG_CHANNEL_CLOSE. It's still important to retag the SSH channel as CHAN_ZOMBIE and clean up its previous data provider.
si...@cda61777-01e9-0310-a592-d414129be87e
Patch from Colin Watson to use g_ascii_strcasecmp in place of the deprecated g_strcasecmp (since all the strings being compared are parts of XLFDs and won't be in interesting character sets anyway).
si...@cda61777-01e9-0310-a592-d414129be87e
Checklist update following the 0.62 release. I managed to send out the announcement email without a subject line, so I'm reorganising the announcement entry in the checklist in the hope that it'll make it harder for me to get that one wrong in future!
si...@cda61777-01e9-0310-a592-d414129be87e
Bump version number on trunk prior to tagging 0.62 on the branch.
si...@cda61777-01e9-0310-a592-d414129be87e
Introduce a function sshfwd_unclean_close(), supplied by ssh.c to subsidiary network modules like portfwd.c. To be called when the subsidiary module experiences a socket error: it sends an emergency CHANNEL_CLOSE (not just outgoing CHANNEL_EOF), and immediately deletes the local side of the channel. (I've invented a new channel type in ssh.c called CHAN_ZOMBIE, for channels whose original local side has already been thrown away and they're just hanging around waiting to receive the acknowledging CHANNEL_CLOSE.) As a result of this and the last few commits, I can now run a port forwarding session in which a local socket error occurs on a forwarded port, and PuTTY now handles it apparently correctly, closing both the SSH channel and the local socket and then actually recognising that it's OK to terminate when all _other_ channels have been closed. Previously the channel corresponding to the duff connection…
si...@cda61777-01e9-0310-a592-d414129be87e
Arrange to call net_pending_errors on Unix, which we've never actually remembered to do before! Also some related fixes, such as that after we do so we should immediately stop selecting on the socket in question.
si...@cda61777-01e9-0310-a592-d414129be87e
When we receive CHANNEL_CLOSE on an SSH-2 channel and haven't sent EOF on it yet, we should send EOF on _that channel_, not the main session channel! Oops.
si...@cda61777-01e9-0310-a592-d414129be87e
Whitespace fix while I was passing.
si...@cda61777-01e9-0310-a592-d414129be87e
Make sure we never send window adjustments (or winadjes) on channels for which we've already sent CHANNEL_CLOSE. It would be embarrassing if the remote end had also sent CHANNEL_CLOSE in response and then received our communication once it had forgotten about the channel.
si...@cda61777-01e9-0310-a592-d414129be87e
Block SIGPIPE in Unix plink. In a port-forwarding run we may have lots of local sockets and pipes all open at once, and if one of them is uncleanly closed from the remote end we don't want the whole application to die - we want to close that socket's SSH channel and continue with the rest of the run.
si...@cda61777-01e9-0310-a592-d414129be87e
Add a missing free_prompts() call in the keyboard-interactive code.
si...@cda61777-01e9-0310-a592-d414129be87e
Tiny patch from Martin Packman to fix a Windows handle leak in Pageant's IPC mechanism. It's incomplete (he sent a much more comprehensive set of fixes that I haven't reviewed), but should be adequate to mitigate a particular issue for Bazaar users.
si...@cda61777-01e9-0310-a592-d414129be87e
I missed a bit in r9343: windows/version.rc2 also needed updating for the new 'pre-release' version type.
si...@cda61777-01e9-0310-a592-d414129be87e
Add a release checklist entry to remind me to get rid of 'pre-release' sections on the Download page.
si...@cda61777-01e9-0310-a592-d414129be87e
Introduce a new version type, 'prerelease'. Quotes the version number it's a pre-release of, and the revision number so you can tell two pre-releases apart. I intend to use this for builds from branch-0.61 until I call it 0.62 proper.
si...@cda61777-01e9-0310-a592-d414129be87e
Support code page 852. Thanks to Tamas Tevesz.
si...@cda61777-01e9-0310-a592-d414129be87e
Private files saved on Unix should have mode 0600, not 0700. They're generally private-key files, which have no need to be executable.
si...@cda61777-01e9-0310-a592-d414129be87e
More arbitrary-limit hunting: retire PASSPHRASE_MAXLEN in the Windows GUIs of Pageant and PuTTYgen. With that and the prompts_t redesign, there should no longer be any limit on passphrase length other than the patience of the user.
si...@cda61777-01e9-0310-a592-d414129be87e
Another utility function, to free a string containing sensitive data.
si...@cda61777-01e9-0310-a592-d414129be87e
Move a recently introduced utility function out of the file in which I declared it static, and into winutils.c where it can be more generally accessible.
si...@cda61777-01e9-0310-a592-d414129be87e
While I'm crusading against arbitrary limits, here's a redesign of prompt_t to arrange that the buffer in which each prompt is stored can be reallocated larger during the input process.
si...@cda61777-01e9-0310-a592-d414129be87e
Turn 'Filename' into a dynamically allocated type with no arbitrary length limit, just as I did to FontSpec yesterday.
ja...@cda61777-01e9-0310-a592-d414129be87e
Fix copy-and-paste error in command-line font selection in r9314.
si...@cda61777-01e9-0310-a592-d414129be87e
Change the semantics of 'FontSpec' so that it's a dynamically allocated type. The main reason for this is to stop it from taking up a fixed large amount of space in every 'struct value' subunion in conf.c, although that makes little difference so far because Filename is still doing the same thing (and is therefore next on my list). However, the removal of its arbitrary length limit is not to be sneezed at.
si...@cda61777-01e9-0310-a592-d414129be87e
We shouldn't fork off a utmp helper subprocess when we aren't setuid, because (a) under that circumstance we won't be writing to utmp anyway, and (b) if we aren't setuid, then we won't have created the pty at the point we fork, so even if our subprocess _could_ have written to utmp it wouldn't have done it right! Spotted by valgrind (triggering on the access beyond the end of the ttyname string in setup_utmp, clueing me in to it having been empty).
si...@cda61777-01e9-0310-a592-d414129be87e
Add a missing initialisation to NULL.
si...@cda61777-01e9-0310-a592-d414129be87e
Cope with XFontStructs having a NULL per_char array, which happened to me this morning under strange circumstances.
si...@cda61777-01e9-0310-a592-d414129be87e
Fix x11font_has_glyph so it doesn't get caught out by signed chars.
  1. Prev
  2. Next