different ROM versions not being imported as expected

Issue #5537 new
Sam created an issue

I noticed that when I tried to import an alternate version (eg translated ROM) of an already-imported game, LaunchBox would not import it when the default “combine ROMs with matching titles into a single game” is selected. It would report 0 game imported afterwards. Instead, I had to re-do the import by one of two ways: 1) use “force importing duplicate game” (creating a duplicate), or 2) delete the existing game and re-import all versions together (no duplicate).

This behavior was unexpected because the alternate ROM does have the same matching main title so I expected it to be combined into the existing game under “additional app”.

Edit: if this was the intended behavior, may I suggest that we at least clarify what “ROMs” the function is referring to, such as by adding a question-mark pop-up note that this function will not combine with any existing ROMs, and that if a different version already exists then it would not be imported unless we pick “force importing duplicate” – although my natural reaction as a user would be to ask, “why not, isn’t that what I’m trying to do now by importing a different version and selecting combining ROMs?” For that reason, I would suggest that we enhance this function to combine with ROMs in the library as well, and avoid the disappointing “0 game imported” message unless the same version already exists (when that happens, an additional message such as “1 of the ROM versions already exist in the library” can be helpful). Also, the user may need a note to understand whether “duplicate” means different versions of the same game, or the same version of the same game.

Comments (3)

  1. Retro808

    The “combine roms with matching titles” looks like it is only doing it for multiple games imported at once. It is not looking at it as a “Combine with already existing games” as well. The issue though is even if you check “Force Import Duplicate” and the “Combine Roms…” option at the same time it does not combine with the existing import. It could be that it is supposed to work and is not, so I will mention it to the team.

    So I would say edit your ticket to be a feature update and request the “Combine Roms…” import option is expanded to search against existing games in library to allow it to then search your library and combine a new import with an existing one.

  2. Sam reporter

    Personally when I read the phrase “combine roms with matching titles”, I interpreted “roms” without qualifiers to mean all roms, including the roms being imported as well as the existing roms in the library; at least, it wasn’t obvious to me that those should be separate groups. As I recall “force import duplicate” and “combine roms…” did not work as I would expect, that’s right. Sure I can change the ticket to be a different request.

  3. Log in to comment