Non-roots can become final after construction

[Jesper Öqvist]

Non-root subtypes of root nodes are set to final via the super-constructor of the root type. This should not happen.

This bug can be fixed by not setting the final-flag in the constructor of a root type that has non-root subtypes.

[Jesper Mattsson]

If you have a root type that is not abstract and has non-root subtypes, wouldn't the proposed fix mean that roots of that type would not become final?

Another possibility would be to unset the flag in the constructors of the non-root subclasses of root types.

[Jesper Öqvist]

Edit title to better describe the problem.

[Jesper Mattsson]

Might need coordination with #234?

[Jesper Öqvist]

Final flags are not used with circular NTA rewrites. Our goal is to eventually remove legacy rewrites in favor of circular NTA rewrites which makes this issue obsolete. I'm closing this now so we can focus on things we are actually working on.