1. Joe Clark
  2. example-confluence-sso-authenticator
  3. Issues
Issue #2 open

Add support for Confluence 5.x

Gary Weaver
created an issue

Joe,

Not sure if your authenticator would have the following problem, but if users get:

2013-03-04 11:14:12,113 ERROR [TP-Processor3] [EXAMPLE.COM].[/].[action]] log Servlet.service() for servlet action threw exception
java.lang.IllegalAccessError: tried to access method com.atlassian.confluence.event.events.security.SecurityEvent.<init>(Ljava/lang/Object;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;)V from class (the authenticator class)

We just had a patch contributed that builds with Confluence 5.x and sets the LoginEvent type to fix this: https://github.com/bananastalktome/confluence_http_authenticator/commit/87079b9d1241d57e9ea84cf4fc6db0a3928e1626

like:

getEventPublisher().publish(new LoginEvent(this, username, request.getSession().getId(), remoteHost, remoteIP, LoginEvent.UNKNOWN));

Please ignore if this isn't relevant.

Comments (3)

  1. Joe Clark repo owner

    Hey Gary. Thanks for reporting this! Sorry I didn't see this earlier - I have Bitbucket notifications turned off since I get so darn many of them.

    This is indeed a breaking API change in Confluence 5 - what a pain! I've reported it here: https://jira.atlassian.com/browse/CONF-28576

    I can work with the Confluence team to get this reverted, and probably shipped in Confluence 5.0.4 - would that even be helpful for you? Or is it too late now and the cat's out of the bag and it's better off just keeping with the current API now?

    Let me know what you think the most useful course of action would be. Joe.

  2. Gary Weaver reporter

    Joe, it was just a heads up. I think it is probably fine that we had to do a 5.0.x specific release (since it was a major version change). Thanks, though!

  3. Log in to comment