Incorrect delegations from PrintObj to ViewObj
Issue #16
resolved
FinInG currently violates the delegation rules for printing and viewing described in section 6.3 of the GAP reference manual. Overall, it shouldn't be difficult to fix this, just replace the ViewObj calls by PrinObj calls. Here is the report generated by CheckOutputDelegations()
.
gap> LoadPackage("fining",false);
true
gap> ReadGapRoot("tst/testutil.g");
gap> CheckOutputDelegations();
All delegations correct for Display
All delegations correct for ViewObj
Detected incorrect delegations for PrintObj
---------------------------------------------------------------
PrintObj: for a Grassmann variety
delegates to [ "ViewObj" ]
Filename: GAPROOT/pkg/fining/lib/varieties.gi:1658
function ( gv )
Print( "Grassmann Variety in " );
ViewObj( gv!.geometry );
return;
end
---------------------------------------------------------------
PrintObj: for a Veronese variety
delegates to [ "ViewObj" ]
Filename: GAPROOT/pkg/fining/lib/varieties.gi:1265
function ( var )
Print( "Veronese Variety in " );
ViewObj( var!.geometry );
return;
end
---------------------------------------------------------------
PrintObj: for a Segre variety
delegates to [ "ViewObj" ]
Filename: GAPROOT/pkg/fining/lib/varieties.gi:983
function ( var )
Print( "Segre Variety in " );
ViewObj( var!.geometry );
return;
end
---------------------------------------------------------------
PrintObj: for a quadratic algebraic variety
delegates to [ "ViewObj" ]
Filename: GAPROOT/pkg/fining/lib/varieties.gi:426
function ( var )
Print( "Quadratic Variety in " );
ViewObj( var!.geometry );
return;
end
---------------------------------------------------------------
PrintObj: for a hermitian variety
delegates to [ "ViewObj" ]
Filename: GAPROOT/pkg/fining/lib/varieties.gi:275
function ( var )
Print( "Hermitian Variety in " );
ViewObj( var!.geometry );
return;
end
---------------------------------------------------------------
PrintObj: for an affine variety
delegates to [ "ViewObj" ]
Filename: GAPROOT/pkg/fining/lib/varieties.gi:556
function ( var )
Print( "Affine Variety in " );
ViewObj( var!.geometry );
return;
end
---------------------------------------------------------------
PrintObj: for a projective algebraic variety
delegates to [ "ViewObj" ]
Filename: GAPROOT/pkg/fining/lib/varieties.gi:175
function ( var )
Print( "Projective Variety in " );
ViewObj( var!.geometry );
return;
end
---------------------------------------------------------------
PrintObj: for a Grassmann map
delegates to [ "ViewObj" ]
Filename: GAPROOT/pkg/fining/lib/varieties.gi:1554
function ( map )
Print( "Grassmann Map of " );
ViewObj( map!.source );
return;
end
---------------------------------------------------------------
PrintObj: for a Veronese map
delegates to [ "ViewObj" ]
Filename: GAPROOT/pkg/fining/lib/varieties.gi:1181
function ( veronesemap )
Print( "Veronese Map of " );
ViewObj( veronesemap!.source );
return;
end
---------------------------------------------------------------
PrintObj: for a Segre map
delegates to [ "ViewObj" ]
Filename: GAPROOT/pkg/fining/lib/varieties.gi:855
function ( segremap )
Print( "Segre Map of " );
ViewObj( segremap!.source );
return;
end
---------------------------------------------------------------
All delegations correct for DisplayString
All delegations correct for ViewString
All delegations correct for PrintString
All delegations correct for String
gap>
Comments (4)
-
reporter -
reporter - edited description
-
repo owner Thanks Max for mentioning this! Fixed.
-
repo owner - changed status to resolved
- Log in to comment
Note that in GAP master, this currently requires the fixed version of
CheckOutputDelegations
available from https://github.com/gap-system/gap/pull/2816