1. jek
  2. flatland
  3. Pull requests

Pull requests

#4 Open
Repository
yaworski
Branch
default
Repository
jek
Branch
default

Fix xml attribute escaping in Element's xa property

Bitbucket cannot automatically merge this request.

The commits that make up this pull request have been removed.

Bitbucket cannot automatically merge this request due to conflicts.

Review the conflicts on the Overview tab. You can then either decline the request or merge it manually on your local system using the following commands:

hg update default
hg pull -r default https://bitbucket.org/yaworski/flatland
hg merge e583b21b3406
hg commit -m 'Merged in yaworski/flatland (pull request #4)'
Author
  1. Marcin Jaworski
Reviewers
Description

flatland.schema.base.Element's xa property is using xml.sax.saxutils.quoteattr incorrectly as it strips quotes (single or double) added by quoteattr function without checking which quotes were actually escaped. If value contains double quotes and not single quotes, according to python documentation quoteattr does not escape double quotes but returns string wrapped in single quotes. All it takes for quoteattr to wrap string in double quotes and escape them inside string is to add at least one single quote.

Comments (0)