P2D3::Crash when double-clicking on a filename (try to generate differences)

Issue #252 resolved
André Sintzoff created an issue

MacHg crashes when double-clicking on a filename. According to the message at the bottom left, MacHg is trying to generate differences.

Hereafter, excerpt of the generated trace. I don't know if such kind of trace is usable. I'm definitely more familiar with Python ones ;-).

{{{ Process: MacHg [14039] Path: /Users/as/Downloads/MacHg.app/Contents/MacOS/MacHg Identifier: com.jasonfharris.MachHg Version: 0.9.22 (0.9.22) Code Type: X86 (Native) Parent Process: launchd [240]

Date/Time: 2011-05-05 22:04:48.096 +0200 OS Version: Mac OS X 10.6.7 (10J869) Report Version: 6

Exception Type: EXC_BREAKPOINT (SIGTRAP) Exception Codes: 0x0000000000000002, 0x0000000000000000 Crashed Thread: 9 Dispatch queue: com.apple.root.default-priority

Application Specific Information: objc[14039]: garbage collection is ON Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: ' -[NSFileManager fileSystemRepresentationWithPath:]: nil or empty path argument' *** Call stack at first throw: ( 0 CoreFoundation 0x98a816ba raiseError + 410 1 libobjc.A.dylib 0x954fd509 objc_exception_throw + 56 2 CoreFoundation 0x98a813e8 +[NSException raise:format:arguments:] + 136 3 CoreFoundation 0x98a8135a +[NSException raise:format:] + 58 4 Foundation 0x97a73b5f -[NSFileManager fileSystemRepresentationWithPath:] + 134 5 Foundation 0x97a73ad3 -[NSString(NSPathUtilities) fileSystemRepresentation] + 62 6 MacHg 0x000749e4 -[BDSKTask launch] + 252 7 MacHg 0x000760bb -[TLMTask launch] + 260 8 MacHg 0x0001544b -[MacHgDocument viewDifferencesInCurrentRevisionFor:toRevision:]_block_invoke_2 + 291 9 libSystem.B.dylib 0x95deefc4 _dispatch_call_block_and_release + 16 10 libSystem.B.dylib 0x95de1271 _dispatch_worker_thread2 + 195 11 libSystem.B.dylib 0x95de0d21 _pthread_wqthread + 390 12 libSystem.B.dylib 0x95de0b66 start_wqthread + 30 )

Thread 0: Dispatch queue: com.apple.main-thread 0 libSystem.B.dylib 0x95dbb09a mach_msg_trap + 10 1 libSystem.B.dylib 0x95dbb807 mach_msg + 68 2 com.apple.CoreFoundation 0x989ea37f __CFRunLoopRun + 2079 3 com.apple.CoreFoundation 0x989e9464 CFRunLoopRunSpecific + 452 4 com.apple.CoreFoundation 0x989e9291 CFRunLoopRunInMode + 97 5 com.apple.HIToolbox 0x9019ce04 RunCurrentEventLoopInMode + 392 6 com.apple.HIToolbox 0x9019cbb9 ReceiveNextEventCommon + 354 7 com.apple.HIToolbox 0x9019ca3e BlockUntilNextEventMatchingListInMode + 81 8 com.apple.AppKit 0x91ad078d _DPSNextEvent + 847 9 com.apple.AppKit 0x91acffce -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 156 10 com.apple.AppKit 0x91a92247 -[NSApplication run] + 821 11 com.apple.AppKit 0x91a8a2d9 NSApplicationMain + 574 12 com.jasonfharris.MachHg 0x00002b11 start + 53

Thread 2: 0 libSystem.B.dylib 0x95de1922 kevent + 10 1 com.jasonfharris.MachHg 0x000759d6 +[BDSKTask(Private) _watchQueue] + 91 2 com.apple.Foundation 0x97a7aad0 -[NSThread main] + 45 3 com.apple.Foundation 0x97a7aa80 NSThreadmain__ + 1499 4 libSystem.B.dylib 0x95de87fd _pthread_start + 345 5 libSystem.B.dylib 0x95de8682 thread_start + 34

Thread 7: Dispatch queue: machg.mercurialTaskSerialQueue 0 libSystem.B.dylib 0x95dbb0d6 semaphore_wait_trap + 10 1 libSystem.B.dylib 0x95e49bb5 _dispatch_group_wait_slow + 268 2 com.jasonfharris.MachHg 0x00016a98 -[MacHgDocument viewDifferencesInCurrentRevisionFor:toRevision:]_block_invoke_1 + 954 3 com.jasonfharris.MachHg 0x0000ceed -[MacHgDocument dispatchToMercurialQueuedWithDescription:process:]_block_invoke_1 + 30 4 libSystem.B.dylib 0x95deefc4 _dispatch_call_block_and_release + 16 5 libSystem.B.dylib 0x95de1a2c _dispatch_queue_drain + 249 6 libSystem.B.dylib 0x95de1488 _dispatch_queue_invoke + 50 7 libSystem.B.dylib 0x95de129e _dispatch_worker_thread2 + 240 8 libSystem.B.dylib 0x95de0d21 _pthread_wqthread + 390 9 libSystem.B.dylib 0x95de0b66 start_wqthread + 30

Thread 9 Crashed: Dispatch queue: com.apple.root.default-priority 0 com.apple.CoreFoundation 0x98acca37 TERMINATING_DUE_TO_UNCAUGHT_EXCEPTION + 7 1 libobjc.A.dylib 0x954fd509 objc_exception_throw + 56 2 com.apple.CoreFoundation 0x98a813e8 +[NSException raise:format:arguments:] + 136 3 com.apple.CoreFoundation 0x98a8135a +[NSException raise:format:] + 58 4 com.apple.Foundation 0x97a73b5f -[NSFileManager fileSystemRepresentationWithPath:] + 134 5 com.apple.Foundation 0x97a73ad3 -[NSString(NSPathUtilities) fileSystemRepresentation] + 62 6 com.jasonfharris.MachHg 0x000749e4 -[BDSKTask launch] + 252 7 com.jasonfharris.MachHg 0x000760bb -[TLMTask launch] + 260 8 com.jasonfharris.MachHg 0x0001544b __-[MacHgDocument viewDifferencesInCurrentRevisionFor:toRevision:]_block_invoke_2 + 291 9 libSystem.B.dylib 0x95deefc4 _dispatch_call_block_and_release + 16 10 libSystem.B.dylib 0x95de1271 _dispatch_worker_thread2 + 195 11 libSystem.B.dylib 0x95de0d21 _pthread_wqthread + 390 12 libSystem.B.dylib 0x95de0b66 start_wqthread + 30

Thread 9 crashed with X86 Thread State (32-bit): eax: 0x00000000 ebx: 0x954fd4e5 ecx: 0xb04b1000 edx: 0x0000003b edi: 0xa0717af0 esi: 0x0146d1f0 ebp: 0xb04b0c38 esp: 0xb04b0c20 ss: 0x0000001f efl: 0x00000282 eip: 0x98acca37 cs: 0x00000017 ds: 0x0000001f es: 0x0000001f fs: 0x0000001f gs: 0x00000037 cr2: 0xffe17110

}}}

Comments (6)

  1. Jason Harris repo owner

    Thanks for the report! But this is fixed in the latest version... I released it yesterday.

    That is MacHg 0.9.22 has been released and includes this fix.

    Thanks, Jas See #244

    Thank, Jas

    Duplicate of #244.

  2. André Sintzoff reporter

    The MacHg I tried to use was 0.9.22.

    AFAIK it is the most recent one.

    IMO, the issue is therefore not solved.

  3. Jason Harris repo owner

    Ok I just released MacHg 0.9.23 to solve this for all diff tools. Sorry that I missed this in MacHg 0.9.22.

    Can you please download 0.9.23 and confirm this is fixed for you?

    Thanks, Jason

  4. Log in to comment