1. jhove2
  2. main

Issues

Issue #132 resolved

Tool to confirm that all Messages are represented in jhove2_messages.properties file

Sheila Morrissey
created an issue

Explore if we can create a tool to be used as part of code review and/or build to make sure that, for any Messages we create, we have made entries in jhove2_message.properties file

Comments (8)

  1. Sheila Morrissey reporter

    Ran tool; have updated jhove2_messages.properties file and pushed to my fork: MessagesChecker: Property file path = C:\jhove2-src\jhove2-sheila\config\messages\jhove2_messages.properties MessagesChecker: Java file-or-dir path = C:\jhove2-src\jhove2-sheila\src\main\java\org\jhove2 Number of properties file keys: 153 Number of Java file keys: 159

    The following message keys were found in Java code but not in properties file

    Fixed as typos org.jhove2.module.format.icc.ICCTag.invalidTechnologySignature org.jhove2.module.format.tiff.IFDEntry.tileLengthNotMultipleof16Message org.jhove2.module.format.tiff.IFDEntry.tileWidthNotMultipleof16Message org.jhove2.module.format.tiff.TiffIFD.ColorMapNotDefinedForPalletteColorMessage org.jhove2.module.format.tiff.TiffIFD.photometricInterpretationSppLT1InvalidMessage

    Fixed by adding new messages org.jhove2.module.format.tiff.IFD.zeroIFDEntriesMessage org.jhove2.module.format.tiff.IFDEntry.InvalidCountValueMessage org.jhove2.module.format.tiff.TiffIFD.InvalidStripOffsetMessage org.jhove2.module.format.tiff.TiffIFD.MissingRequiredTag org.jhove2.module.format.tiff.TiffIFD.TileByteCountsNotDefinedMessage org.jhove2.module.format.tiff.TiffIFD.TileLengthNotDefinedMessage org.jhove2.module.format.tiff.TiffIFD.TileOffsetsNotDefinedMessage org.jhove2.module.format.tiff.TiffIFD.TileWidthNotDefinedMessage org.jhove2.module.format.tiff.TiffIFD.TilesAndStripsNotDefinedMessage org.jhove2.module.format.wave.WaveModule.missingRequiredFactChunk org.jhove2.module.format.wave.WaveModule.missingRequiredFormatChunk org.jhove2.module.format.wave.bwf.PeakEnvelopeChunk.nonNULDataInReservedField

    The following message keys were found in the properties file but not in Java code

    Fixed as typos
    org.jhove2.module.format.icc.ICCTag.InvalidTechnologySignatureType
    org.jhove2.module.format.tiff.IFDEntry.TileLengthNotMultipleOf16Message
    org.jhove2.module.format.tiff.IFDEntry.TileWidthNotMultipleOf16Message
    org.jhove2.module.format.tiff.TiffIFD.ColorMapNotDefinedForPalleteColorMessage
    org.jhove2.module.format.tiff.TiffIFD.PhotometricInterpretationSppLT1InvalidMessage
    
    Commented out
    org.jhove2.module.format.icc.ICCModule.PrematureEOF 
    org.jhove2.module.format.icc.profile.ThreeComponentMatrixBasedDisplayProfile.PCSNotXYZ
    org.jhove2.module.format.riff.Chunk.invalidListType 
    org.jhove2.module.format.xml.XmlModule.invalidNumericCharacterReference
    org.jhove2.module.format.zip.ZipLocalFileHeader.invalidCompression
    org.jhove2.module.format.zip.ZipLocalFileHeader.invalidVersion
    
  2. Log in to comment