Anonymous avatar Anonymous committed 7be2e95

Update.

Comments (0)

Files changed (5)

src/META-INF/upgrade/j.l.Thread.sleep.hint

+<?
+import javax.lang.model.element.Modifier;
+?>
+
+'Thread.sleep in synchronized context':
+Thread.sleep($time) :: inSynchronizedContext($_);;
+
+<?
+    private boolean inSynchronizedContext(Variable current) {
+        while (current != null) {
+            //current is synchronized block:
+            if (matcher.matches(current, "synchronized ($lock) { $stmts$; }")) return true;
+            //current is a method:
+            if (matcher.matches(current, "$mods$ $type $methodName($args$) throws $throws$ { $stmts$; }")) {
+                return context.modifiers(current).contains(Modifier.SYNCHRONIZED);
+            }
+            //current is a class:
+            if (matcher.matches(current, "$mods$ class $className extends $ext$ implements $i$ { $stmts$; }")) {
+                return false;
+            }
+
+            System.err.println(context.name(current));
+            current = context.parent(current);
+        }
+
+        return false;
+    }
+?>

src/META-INF/upgrade/j.u.c.l.Lock.hint

+$lock.lock();
+$statements$;
+$lock.unlock(); :: $lock instanceof java.util.concurrent.locks.Lock
+=>
+$lock.lock();
+try {
+    $statements$;
+} finally {
+    $lock.unlock();
+}
+;;

src/META-INF/upgrade/o.o.u.Utilities.hint

-//org.openide.util.Utilities.loadImage($loc) => org.openide.util.ImageUtilities.loadImage($loc);;
+Xorg.openide.util.Utilities.loadImage($loc)
+=>
+org.openide.util.ImageUtilities.loadImage($loc)
+;;

src/demo/Locking.java

+package demo;
+
+import java.util.concurrent.locks.Lock;
+
+public class Locking {
+
+    public static void runUnderLock(Lock l, Runnable r) {
+        l.lock();
+        r.run();
+        l.unlock();
+    }
+    
+}

src/demo/SleepInSynchronized.java

+package demo;
+
+import org.openide.util.Exceptions;
+
+public class SleepInSynchronized {
+
+    public synchronized void sleep1() throws InterruptedException {
+        Thread.sleep(1000);
+    }
+    
+    public void sleep2() throws InterruptedException {
+        synchronized (this) {
+            Thread.sleep(1000);
+        }
+    }
+    
+    public void sleep3() throws InterruptedException {
+        Thread.sleep(1000);
+    }
+
+    public synchronized void sleep4() {
+        class Local {
+            {
+                try {
+                    Thread.sleep(1000);
+                } catch (InterruptedException ex) {
+                    Exceptions.printStackTrace(ex);
+                }
+            }
+        }
+    }
+}
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.