Compilation errors not reported for custom rules (quietly ignored)

Ernie Rael avatarErnie Rael created an issue

This patch checks for, and provides the display of, compiler errors for custom patches. When a compilation error is detected a

Display Compiler Errors

button is made visible. When this button is pressed there's a dialog to display the errors.

The line numbers are not correct; that could probably be fixed. But, at least for me, it's vastly improved behavior.

The patch is a little ugly; I wanted to minimize changes to how the compiler is invoked and it's partly due to the interactions with stuff in NB. I was going to return custom ProblemDetails but the class is final.

I apply this patch after the patch in issue 17.

Comments (0)

  1. Log in to comment
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.